From: Ole Troan <ot@cisco.com>
Date: Tue, 3 Sep 2019 18:58:08 +0000 (+0200)
Subject: stats: memory leak with per-node-counters on
X-Git-Tag: v19.08.2~342
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=2160efbaf11b0675e30fc1f901e116f88c0302f5;p=vpp.git

stats: memory leak with per-node-counters on

vlib_node_get_nodes() creates a duplicate node structure which was never freed.

Type: fix
Fixes: 1ddbc0138b
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib1200854937faaa694b398607d2f0ba65aa81c01
(cherry picked from commit b6fde4a8bae474c6b73d08d223028f42e396d452)
---

diff --git a/src/vpp/stats/stat_segment.c b/src/vpp/stats/stat_segment.c
index 1328ea815ae..5dcb390e7ae 100644
--- a/src/vpp/stats/stat_segment.c
+++ b/src/vpp/stats/stat_segment.c
@@ -527,7 +527,10 @@ update_node_counters (stat_segment_main_t * sm)
 	  c[n->index] =
 	    n->stats_total.suspends - n->stats_last_clear.suspends;
 	}
+      vec_free (node_dups[j]);
     }
+  vec_free (node_dups);
+  vec_free (stat_vms);
 }
 
 static void