From: Ole Troan <ot@cisco.com>
Date: Mon, 9 May 2016 10:23:45 +0000 (+0200)
Subject: VPP-20: Verify valid sw_if_index in ip_address_dump.
X-Git-Tag: v16.06-rc1~35
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=30d41fff9b649b6bc4c24af8c4059da7ad121de4;p=vpp.git

VPP-20: Verify valid sw_if_index in ip_address_dump.
        (Also checked other API calls for same error without finding any.)

Change-Id: I1062ecf8eff004efb3fad4582a00c6b512c36999
Signed-off-by: Ole Troan <ot@cisco.com>
---

diff --git a/vpp/api/api.c b/vpp/api/api.c
index 18c00bd3d22..c672d4a309a 100644
--- a/vpp/api/api.c
+++ b/vpp/api/api.c
@@ -3931,6 +3931,9 @@ vl_api_ip_address_dump_t_handler (vl_api_ip_address_dump_t *mp)
     ip_lookup_main_t * lm4 = &im4->lookup_main;
     ip_interface_address_t * ia = 0;
     u32 sw_if_index = ~0;
+    int rv __attribute__ ((unused)) = 0;
+
+    VALIDATE_SW_IF_INDEX(mp);
 
     sw_if_index = ntohl(mp->sw_if_index);
 
@@ -3956,6 +3959,7 @@ vl_api_ip_address_dump_t_handler (vl_api_ip_address_dump_t *mp)
             send_ip_address_details(am, q, (u8*)r4, prefix_length, 0, mp->context);
         }));
     }
+    BAD_SW_IF_INDEX_LABEL;
 }
 
 static void send_ip_details (vpe_api_main_t * am,