From: Benoît Ganne <bganne@cisco.com>
Date: Thu, 26 Jan 2023 16:16:54 +0000 (+0100)
Subject: fib: keep AddressSanitizer happy
X-Git-Tag: v23.10-rc0~278
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=3220d9f16b3db05fe9ea8d756395cd8aa7755863;p=vpp.git

fib: keep AddressSanitizer happy

adj_delegate_remove() makes 'ad' invalid, invalidate it only after its
use.

Type: fix

Change-Id: I6908d3dd2962ebd3fdf37e946cb19dae727bda09
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/vnet/adj/adj_midchain_delegate.c b/src/vnet/adj/adj_midchain_delegate.c
index de57442ac9b..16129ff86ac 100644
--- a/src/vnet/adj/adj_midchain_delegate.c
+++ b/src/vnet/adj/adj_midchain_delegate.c
@@ -148,12 +148,11 @@ adj_midchain_delegate_remove (adj_index_t ai)
     {
         adj_nbr_midchain_unstack(ai);
 
-        adj_delegate_remove (ai, ADJ_DELEGATE_MIDCHAIN);
-
         amd = pool_elt_at_index(amd_pool, ad->ad_index);
         fib_entry_untrack(amd->amd_fei, amd->amd_sibling);
-
         pool_put(amd_pool, amd);
+
+        adj_delegate_remove (ai, ADJ_DELEGATE_MIDCHAIN);
     }
 }