From: Dave Barach <dave@barachs.net>
Date: Wed, 20 Sep 2017 12:40:16 +0000 (-0400)
Subject: Improve API message handler re-registration check
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=392206e55a1cbfb0a2e03ae310a4d3953bf3f194;p=odp4vpp.git

Improve API message handler re-registration check

Change-Id: Iedcea2fb45052852666b91a21eed011f5593313d
Signed-off-by: Dave Barach <dave@barachs.net>
---

diff --git a/src/vlibapi/api_shared.c b/src/vlibapi/api_shared.c
index 59dc2375..0c4952b1 100644
--- a/src/vlibapi/api_shared.c
+++ b/src/vlibapi/api_shared.c
@@ -671,9 +671,11 @@ vl_msg_api_config (vl_msg_api_msg_config_t * c)
   foreach_msg_api_vector;
 #undef _
 
-  if (am->msg_names[c->id])
-    clib_warning ("BUG: multiple registrations of 'vl_api_%s_t_handler'",
-		  c->name);
+  if (am->msg_handlers[c->id] && am->msg_handlers[c->id] != c->handler)
+    clib_warning
+      ("BUG: re-registering 'vl_api_%s_t_handler'."
+       "Handler was %llx, replaced by %llx",
+       c->name, am->msg_handlers[c->id], c->handler);
 
   am->msg_names[c->id] = c->name;
   am->msg_handlers[c->id] = c->handler;