From: Florin Coras <fcoras@cisco.com>
Date: Tue, 1 Aug 2023 17:53:22 +0000 (-0700)
Subject: quic: fix closing of streams
X-Git-Tag: v24.02-rc0~99
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=39a8e164486d74e1d4ded5cb83e5a5fec93db3b1;p=vpp.git

quic: fix closing of streams

Avoid explicit manipulation of session state and generate closing event
if need be.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I07cda1db08a2673b27b496ea1371b0dfd8e6f98a
---

diff --git a/src/plugins/quic/quic.c b/src/plugins/quic/quic.c
index d950df524cc..c3c4540353b 100644
--- a/src/plugins/quic/quic.c
+++ b/src/plugins/quic/quic.c
@@ -784,12 +784,10 @@ quic_on_stream_destroy (quicly_stream_t * stream, int err)
   quic_stream_data_t *stream_data = (quic_stream_data_t *) stream->data;
   quic_ctx_t *sctx = quic_ctx_get (stream_data->ctx_id,
 				   stream_data->thread_index);
-  session_t *stream_session = session_get (sctx->c_s_index,
-					   sctx->c_thread_index);
   QUIC_DBG (2, "DESTROYED_STREAM: session 0x%lx (%U)",
 	    session_handle (stream_session), quic_format_err, err);
 
-  stream_session->session_state = SESSION_STATE_CLOSED;
+  session_transport_closing_notify (&sctx->connection);
   session_transport_delete_notify (&sctx->connection);
 
   quic_increment_counter (QUIC_ERROR_CLOSED_STREAM, 1);