From: Florin Coras <fcoras@cisco.com>
Date: Tue, 7 Jan 2025 09:45:05 +0000 (-0500)
Subject: hs-test: cleanup nsim test
X-Git-Tag: v25.06-rc0~56
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=3a3476fddb79ed1eaf277bb66c0641933906ef3d;p=vpp.git

hs-test: cleanup nsim test

After nsim fixes in gerrit 42052 echo tests with nsim should be stable
with multiple workers and should no longer require a ping to work.

Type: improvement

Change-Id: Ice4b353153c57b547df60d21723fa8cf953ca5d0
Signed-off-by: Florin Coras <fcoras@cisco.com>
---

diff --git a/extras/hs-test/echo_test.go b/extras/hs-test/echo_test.go
index f27ad077928..b21c69a1e99 100644
--- a/extras/hs-test/echo_test.go
+++ b/extras/hs-test/echo_test.go
@@ -24,9 +24,7 @@ func EchoBuiltinTest(s *VethsSuite) {
 	s.AssertNotContains(o, "failed:")
 }
 
-// unstable with multiple workers
 func TcpWithLossTest(s *VethsSuite) {
-	s.SkipIfMultiWorker()
 	serverVpp := s.Containers.ServerVpp.VppInstance
 
 	serverVpp.Vppctl("test echo server uri tcp://%s/20022",
@@ -34,10 +32,6 @@ func TcpWithLossTest(s *VethsSuite) {
 
 	clientVpp := s.Containers.ClientVpp.VppInstance
 
-	// Ensure that VPP doesn't abort itself with NSIM enabled
-	// Warning: Removing this ping will make VPP crash!
-	clientVpp.Vppctl("ping %s", s.Interfaces.Server.Ip4AddressString())
-
 	// Add loss of packets with Network Delay Simulator
 	clientVpp.Vppctl("set nsim poll-main-thread delay 0.01 ms bandwidth 40 gbit" +
 		" packet-size 1400 packets-per-drop 1000")