From: Florin Coras <fcoras@cisco.com>
Date: Mon, 28 Oct 2024 18:49:34 +0000 (-0700)
Subject: udp: connected mode only for connects
X-Git-Tag: v25.06-rc0~181
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=3b290df57ce9357abd0ecd8126ef8f4c1d725615;p=vpp.git

udp: connected mode only for connects

Treat all connects as connected udp sessions. Connectionless udp is only
possible with listeners.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I0a75b7c85b72274df909ed3b114eed4f6519477e
---

diff --git a/src/vnet/udp/udp.c b/src/vnet/udp/udp.c
index 8deeb9e41ee..1fc055f8d50 100644
--- a/src/vnet/udp/udp.c
+++ b/src/vnet/udp/udp.c
@@ -467,16 +467,7 @@ udp_open_connection (transport_endpoint_cfg_t * rmt)
   uc->mss = rmt->mss ? rmt->mss : udp_default_mtu (um, uc->c_is_ip4);
   if (rmt->peer.sw_if_index != ENDPOINT_INVALID_INDEX)
     uc->sw_if_index = rmt->peer.sw_if_index;
-  uc->flags |= UDP_CONN_F_OWNS_PORT;
-  if (rmt->transport_flags & TRANSPORT_CFG_F_CONNECTED)
-    {
-      uc->flags |= UDP_CONN_F_CONNECTED;
-    }
-  else
-    {
-      clib_spinlock_init (&uc->rx_lock);
-      uc->c_flags |= TRANSPORT_CONNECTION_F_CLESS;
-    }
+  uc->flags |= UDP_CONN_F_OWNS_PORT | UDP_CONN_F_CONNECTED;
   if (!um->csum_offload)
     uc->cfg_flags |= UDP_CFG_F_NO_CSUM_OFFLOAD;
   uc->next_node_index = rmt->next_node_index;