From: Ole Troan <ot@cisco.com>
Date: Mon, 15 Feb 2021 23:42:21 +0000 (+0100)
Subject: vppapigen: coveriy missing check of return values
X-Git-Tag: v21.10-rc0~518
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=5993a34a12cb41f83ced26893b977b4eb2947708;p=vpp.git

vppapigen: coveriy missing check of return values

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I424c2f283dab99c1856eb8d9a1444486d09e8e29
---

diff --git a/src/vat2/jsonconvert.c b/src/vat2/jsonconvert.c
index 35279eebb5f..fa41e7988e2 100644
--- a/src/vat2/jsonconvert.c
+++ b/src/vat2/jsonconvert.c
@@ -42,7 +42,8 @@ int vl_api_u8_string_fromjson(cJSON *o, u8 *s, int len)
     unformat_input_t input;
     char *p = cJSON_GetStringValue(o);
     unformat_init_string (&input, p, strlen(p));
-    unformat(&input, "0x%U", unformat_hex_string, s);
+    if (!unformat (&input, "0x%U", unformat_hex_string, s))
+      return -1;
     return 0;
 }
 
@@ -59,7 +60,8 @@ u8string_fromjson(cJSON *o, char *fieldname)
 
     char *p = cJSON_GetStringValue(item);
     unformat_init_string (&input, p, strlen(p));
-    unformat(&input, "0x%U", unformat_hex_string, &s);
+    if (!unformat (&input, "0x%U", unformat_hex_string, &s))
+      return 0;
     return s;
 }