From: Steven Luong <sluong@cisco.com>
Date: Mon, 16 May 2022 22:53:43 +0000 (-0700)
Subject: acl: memory leak in acl_fa_session_cleaner_process
X-Git-Tag: v22.10-rc0~23
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=59a08e65094db28884fc40e9562e303fde3b21d8;p=vpp.git

acl: memory leak in acl_fa_session_cleaner_process

The statement
  pw0->pending_clear_sw_if_index_bitmap =
    clib_bitmap_dup (pw0->serviced_sw_if_index_bitmap);
will cause pw0->pending_clear_sw_if_index_bitmap's previous
vector to be gone. Need to free it prior to calling clib_bitmap_dup()

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I20de780e73daea7be17efa0bf660af2592cd4680
---

diff --git a/src/plugins/acl/sess_mgmt_node.c b/src/plugins/acl/sess_mgmt_node.c
index d0ec5936896..eb73fd0bb45 100644
--- a/src/plugins/acl/sess_mgmt_node.c
+++ b/src/plugins/acl/sess_mgmt_node.c
@@ -723,6 +723,7 @@ acl_fa_session_cleaner_process (vlib_main_t * vm, vlib_node_runtime_t * rt,
 		}
 	      else
 		{
+		  clib_bitmap_free (pw0->pending_clear_sw_if_index_bitmap);
 		  if (clear_all)
 		    {
 		      /* if we need to clear all, then just clear the interfaces that we are servicing */