From: Vladimir Kropylev <vladimir.kropylev@enea.com>
Date: Fri, 30 Aug 2019 10:04:06 +0000 (+0300)
Subject: session: move svm_fifo_clear_deq_ntf to before calling the app callback
X-Git-Tag: v20.05-rc0~905
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=5c89fbf28665d13a0052fc88288c1524e0e93918;p=vpp.git

session: move svm_fifo_clear_deq_ntf to before calling the app callback

Type: fix

in case the app requests another dequeue notification, it should not be cleared

Change-Id: I7e94e8e30ef098f87f5e7f4880af276970ee5b37
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>
---

diff --git a/src/vnet/session/session.c b/src/vnet/session/session.c
index a27e80ea336..1010f0525ba 100644
--- a/src/vnet/session/session.c
+++ b/src/vnet/session/session.c
@@ -604,6 +604,8 @@ session_dequeue_notify (session_t * s)
 {
   app_worker_t *app_wrk;
 
+  svm_fifo_clear_deq_ntf (s->tx_fifo);
+
   app_wrk = app_worker_get_if_valid (s->app_wrk_index);
   if (PREDICT_FALSE (!app_wrk))
     return -1;
@@ -616,8 +618,6 @@ session_dequeue_notify (session_t * s)
     return session_notify_subscribers (app_wrk->app_index, s,
 				       s->tx_fifo, SESSION_IO_EVT_TX);
 
-  svm_fifo_clear_deq_ntf (s->tx_fifo);
-
   return 0;
 }