From: Maros Marsalek <mmarsale@cisco.com>
Date: Thu, 14 Jul 2016 07:54:50 +0000 (+0200)
Subject: Add google's error prone static analysis to build
X-Git-Tag: v1.17.01-RC0~227
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=632055ae0e29d16b831519b095b5c34dd430e19c;p=hc2vpp.git

Add google's error prone static analysis to build

Can be also integrated with IDEs:
http://errorprone.info/docs/installation

Change-Id: I5f695995078139a077bd9d62c68792207c904e11
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
---

diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/ip/Ipv4NeighbourCustomizer.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/ip/Ipv4NeighbourCustomizer.java
index e01d4c1bf..99267ddff 100644
--- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/ip/Ipv4NeighbourCustomizer.java
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfaces/ip/Ipv4NeighbourCustomizer.java
@@ -88,7 +88,7 @@ public class Ipv4NeighbourCustomizer extends FutureJVppCustomizer
     public void updateCurrentAttributes(@Nonnull InstanceIdentifier<Neighbor> id, @Nonnull Neighbor dataBefore,
                                         @Nonnull Neighbor dataAfter,
                                         @Nonnull WriteContext writeContext) throws WriteFailedException {
-        new UnsupportedOperationException("Operation not supported");
+        throw new UnsupportedOperationException("Operation not supported");
     }
 
     @Override
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java
index 4d1f5dd5d..7b4b2d01e 100644
--- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/v3po/translate/v3po/interfacesstate/InterfaceUtils.java
@@ -121,7 +121,7 @@ public final class InterfaceUtils {
         Objects.requireNonNull(vppPhysAddress, "Empty physical address bytes");
         final int endIndex = startIndex + PHYSICAL_ADDRESS_LENGTH;
         checkArgument(endIndex <= vppPhysAddress.length,
-            "Invalid physical address size (%s) for given startIndex (%d), expected >= %d", vppPhysAddress.length,
+            "Invalid physical address size (%s) for given startIndex (%s), expected >= %s", vppPhysAddress.length,
             startIndex, endIndex);
         StringBuilder physAddr = new StringBuilder();