From: Vratko Polak <vrpolak@cisco.com>
Date: Wed, 11 Sep 2019 10:51:01 +0000 (+0200)
Subject: Mark jobs that should not tolerate CRC mismatch
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=6aad83f2d2f3d57129732153492ca8121f0dab0a;p=ci-management.git

Mark jobs that should not tolerate CRC mismatch

CRC checking is only needed in a small subset of jobs
that are required for maintaining CRCs.
Other jobs are more useful if they skip CRC checking,
in order to uncover real incompatibility (or confirm compatibility).

Change-Id: I08113b3bec5e38650a6e7331a9513feb17908e48
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
---

diff --git a/jjb/csit/csit-func.yaml b/jjb/csit/csit-func.yaml
index c9a98631a..86c9f1c83 100644
--- a/jjb/csit/csit-func.yaml
+++ b/jjb/csit/csit-func.yaml
@@ -191,6 +191,11 @@
           name: ARCHIVE_ARTIFACTS
           default: '{archive-artifacts}'
           description: Artifacts to archive to the logs server.
+      # This is an automatic verify job, part of API coverage.
+      # CRC checking is needed to ensure vpp crc job breaks only when intended.
+      # Can be removed when this job is no longer needed for full API coverage.
+      - csit-fail-on-crc-mismatch-parameter:
+          fail-on-crc-mismatch: 'True'
 
     scm:
       - gerrit-trigger-scm:
diff --git a/jjb/csit/csit-perf.yaml b/jjb/csit/csit-perf.yaml
index bff30d82a..662640098 100644
--- a/jjb/csit/csit-perf.yaml
+++ b/jjb/csit/csit-perf.yaml
@@ -144,6 +144,11 @@
           name: ARCHIVE_ARTIFACTS
           default: '{archive-artifacts}'
           description: Artifacts to archive to the logs server.
+      # This is a manually-triggered verify job, part of API coverage.
+      # CRC checking is needed to ensure vpp crc job breaks only when intended.
+      # Can be removed when this job is no longer needed for full API coverage.
+      - csit-fail-on-crc-mismatch-parameter:
+          fail-on-crc-mismatch: 'True'
 
     scm:
       - gerrit-trigger-scm:
diff --git a/jjb/csit/csit-vpp-device.yaml b/jjb/csit/csit-vpp-device.yaml
index f16dae549..2d1b3cedf 100644
--- a/jjb/csit/csit-vpp-device.yaml
+++ b/jjb/csit/csit-vpp-device.yaml
@@ -127,6 +127,11 @@
           name: ARCHIVE_ARTIFACTS
           default: '{archive-artifacts}'
           description: Artifacts to archive to the logs server.
+      # This is an automatic verify job, part of API coverage.
+      # CRC checking is needed to ensure vpp crc job breaks only when intended.
+      # Unlikely to be removed, as this job is primary source of API coverage.
+      - csit-fail-on-crc-mismatch-parameter:
+          fail-on-crc-mismatch: 'True'
 
     scm:
       - gerrit-trigger-scm:
diff --git a/jjb/global-macros.yaml b/jjb/global-macros.yaml
index a179b1329..a95342196 100644
--- a/jjb/global-macros.yaml
+++ b/jjb/global-macros.yaml
@@ -114,7 +114,7 @@
       - string:
           name: FDIO_CSIT_FAIL_ON_CRC_MISMATCH
           default: '{fail-on-crc-mismatch}'
-          description: "If false, CRC is not checked, so compatibility is tested."
+          description: "If true, CRC is checked, else compatibility is tested."
 
 - parameter:
     name: gerrit-event-type-parameter
diff --git a/jjb/vpp/vpp.yaml b/jjb/vpp/vpp.yaml
index b7b08fca5..dbd3dd79a 100644
--- a/jjb/vpp/vpp.yaml
+++ b/jjb/vpp/vpp.yaml
@@ -832,9 +832,6 @@
           name: ARCHIVE_ARTIFACTS
           default: '{archive-artifacts}'
           description: Artifacts to archive to the logs server.
-      # The API CRC job fails on mismatch, we hunt for real incompatibilities.
-      - csit-fail-on-crc-mismatch-parameter:
-          fail-on-crc-mismatch: 'False'
 
     scm:
       - gerrit-trigger-scm:
@@ -913,9 +910,6 @@
           name: ARCHIVE_ARTIFACTS
           default: '{archive-artifacts}'
           description: Artifacts to archive to the logs server.
-      # The API CRC job fails on mismatch, try compare API versions if possible.
-      - csit-fail-on-crc-mismatch-parameter:
-          fail-on-crc-mismatch: 'False'
 
     scm:
       - gerrit-trigger-scm:
@@ -976,6 +970,10 @@
           name: ARCHIVE_ARTIFACTS
           default: '{archive-artifacts}'
           description: Artifacts to archive to the logs server.
+      # Not sure whether not failing has any useful usage,
+      # but it does not hurt to have some flexibility for future.
+      - csit-fail-on-crc-mismatch-parameter:
+          fail-on-crc-mismatch: 'True'
 
     scm:
       - gerrit-trigger-scm: