From: Ondrej Fabry <ofabry@cisco.com>
Date: Wed, 5 Sep 2018 11:55:54 +0000 (+0200)
Subject: Copy data in msg callback
X-Git-Tag: v0.1.0~47
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=6f6d2433ae72550cb4b603376ae8e6185256affe;p=govpp.git

Copy data in msg callback

Change-Id: I642b0f586a57101633982bcee5bad187a0749090
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
---

diff --git a/core/request_handler.go b/core/request_handler.go
index 14c095d..c042948 100644
--- a/core/request_handler.go
+++ b/core/request_handler.go
@@ -193,11 +193,12 @@ func (c *Connection) msgCallback(msgID uint16, data []byte) {
 	// treat this as a last part of the reply
 	lastReplyReceived := isMulti && msgID == c.pingReplyID
 
-	// send the data to the channel
+	// send the data to the channel, it needs to be copied,
+	// because it will be freed after this function returns
 	sendReply(ch, &vppReply{
 		msgID:        msgID,
 		seqNum:       seqNum,
-		data:         data,
+		data:         append([]byte(nil), data...),
 		lastReceived: lastReplyReceived,
 	})