From: Benoît Ganne <bganne@cisco.com>
Date: Wed, 21 Aug 2019 16:27:23 +0000 (+0200)
Subject: vcl: fix ldp_set_app_name overflow
X-Git-Tag: v20.05-rc0~951
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=747b3d8b0e045edb166738ecde99dcc951212988;p=vpp.git

vcl: fix ldp_set_app_name overflow

In case of overflow, we null-terminate the parameter ('app_name')
instead of ldp global name ('ldp->app_name').
Moreover, snprintf() always safely null-terminate the destination string
even in case of overflow.

Type: fix
Fixes: 048b1d6ab7

Change-Id: I4d8b0e020a228e982b6699d652b341c5afe92993
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/vcl/ldp.c b/src/vcl/ldp.c
index 70a4299083e..7aa38305249 100644
--- a/src/vcl/ldp.c
+++ b/src/vcl/ldp.c
@@ -132,11 +132,8 @@ ldp_worker_get_current (void)
 static inline void
 ldp_set_app_name (char *app_name)
 {
-  int rv = snprintf (ldp->app_name, LDP_APP_NAME_MAX,
-		     "ldp-%d-%s", getpid (), app_name);
-
-  if (rv >= LDP_APP_NAME_MAX)
-    app_name[LDP_APP_NAME_MAX - 1] = 0;
+  snprintf (ldp->app_name, LDP_APP_NAME_MAX,
+	    "ldp-%d-%s", getpid (), app_name);
 }
 
 static inline char *