From: Neale Ranns <nranns@cisco.com>
Date: Sun, 10 Dec 2017 13:32:31 +0000 (-0800)
Subject: BIER coverity Fix
X-Git-Tag: v18.04-rc0~80
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=765b82ba962496fde62c355cd579dfb75f45e093;p=vpp.git

BIER coverity Fix

Change-Id: I17f95775756b8fd5ee390432f6d8041abbd9f974
Signed-off-by: Neale Ranns <nranns@cisco.com>
---

diff --git a/src/vnet/bier/bier_test.c b/src/vnet/bier/bier_test.c
index cf75c2eb072..0fbca7e7b9b 100644
--- a/src/vnet/bier/bier_test.c
+++ b/src/vnet/bier/bier_test.c
@@ -170,15 +170,17 @@ bier_test_validate_entry (index_t bei,
 
     bier_entry_contribute_forwarding(bei, &dpo);
 
-    BIER_TEST_LB((DPO_LOAD_BALANCE == dpo.dpoi_type),
-                 "Entry links to %U",
-                 format_dpo_type, dpo.dpoi_type);
+    res = BIER_TEST_I((DPO_LOAD_BALANCE == dpo.dpoi_type),
+                      "Entry links to %U",
+                      format_dpo_type, dpo.dpoi_type);
 
-    lb = load_balance_get(dpo.dpoi_index);
-    res = fib_test_validate_lb_v(lb, n_buckets, &ap);
+    if (res)
+    {
+        lb = load_balance_get(dpo.dpoi_index);
+        res = fib_test_validate_lb_v(lb, n_buckets, &ap);
+    }
 
     dpo_reset(&dpo);
-
     va_end(ap);
 
     return (res);