From: Ole Troan <ot@cisco.com>
Date: Tue, 8 Dec 2020 19:35:32 +0000 (+0100)
Subject: api: remove unused singular option
X-Git-Tag: v21.06-rc0~34
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=791c2061aedce4e7229be5bad6acee0a6e91e1a9;p=vpp.git

api: remove unused singular option

The singular option to the API language was added as a way to deal with messages
that do not have a reply message. Examples in memclnt.api.
Instead dealt with these messages using the service {} construct.

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If01b390b24b7539d1f93de4b8edfe1dad08e509d
---

diff --git a/src/tools/vppapigen/vppapigen.py b/src/tools/vppapigen/vppapigen.py
index b80dd4d9f7d..0782dd294ab 100755
--- a/src/tools/vppapigen/vppapigen.py
+++ b/src/tools/vppapigen/vppapigen.py
@@ -308,7 +308,6 @@ class Define(Processable):
         self.manual_print = False
         self.manual_endian = False
         self.autoreply = False
-        self.singular = False
         self.options = {}
         for f in flags:
             if f == 'dont_trace':
@@ -323,10 +322,7 @@ class Define(Processable):
         remove = []
         for b in block:
             if isinstance(b, Option):
-                if b[1] == 'singular' and b[2] == 'true':
-                    self.singular = True
-                else:
-                    self.options[b.option] = b.value
+                self.options[b.option] = b.value
                 remove.append(b)
 
         block = [x for x in block if x not in remove]
@@ -1042,8 +1038,6 @@ class VPPAPI():
         for d in msgs:
             if d in seen_services:
                 continue
-            if msgs[d].singular is True:
-                continue
             if d.endswith('_reply'):
                 if d[:-6] in svcs:
                     continue