From: Daniel Béreš <daniel.beres@pantheon.tech>
Date: Mon, 4 Oct 2021 07:51:59 +0000 (+0000)
Subject: nat: VPP crashes when route is not reachable
X-Git-Tag: v22.06-rc0~237
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=79ce5142284084caee420ee18d47df145503c4db;p=vpp.git

nat: VPP crashes when route is not reachable

The problem was reproducible only with icmp packet type
when det44 in, out interfaces were swapped.
Dst addr was unknown but packet has been forwarded.

Type: fix
Ticket: VPP-1958

Signed-off-by: Daniel Béreš <daniel.beres@pantheon.tech>
Change-Id: Ie446cf2ac866955cc668fe2848f954a2ef92e3fa
---

diff --git a/src/plugins/nat/det44/det44_out2in.c b/src/plugins/nat/det44/det44_out2in.c
index 111bc61c476..4871e752db0 100644
--- a/src/plugins/nat/det44/det44_out2in.c
+++ b/src/plugins/nat/det44/det44_out2in.c
@@ -173,6 +173,9 @@ icmp_match_out2in_det (vlib_node_runtime_t * node,
 	}
       det44_log_info ("unknown dst address:  %U",
 		      format_ip4_address, &ip0->dst_address);
+      b0->error = node->errors[DET44_OUT2IN_ERROR_NO_TRANSLATION];
+      next0 = DET44_OUT2IN_NEXT_DROP;
+
       goto out;
     }