From: Florin Coras <fcoras@cisco.com>
Date: Thu, 7 Nov 2024 21:44:02 +0000 (-0800)
Subject: hsa: proxy fix assert placement
X-Git-Tag: v25.06-rc0~166
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=7fdb6f4ba8dd7f934d2eb212b478086565d3d807;p=vpp.git

hsa: proxy fix assert placement

Assert fifo refcnt on the right thread

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If6edf9969f5c70533a1e9c6358c022c556c4ed81
---

diff --git a/src/plugins/hs_apps/proxy.c b/src/plugins/hs_apps/proxy.c
index 0d24ebc6525..7079da5eb94 100644
--- a/src/plugins/hs_apps/proxy.c
+++ b/src/plugins/hs_apps/proxy.c
@@ -346,8 +346,6 @@ proxy_try_delete_session (session_t * s, u8 is_active_open)
       /* Passive open already cleaned up */
       if (ps->po.session_handle == SESSION_INVALID_HANDLE)
 	{
-	  ASSERT (s->rx_fifo->refcnt == 1);
-
 	  /* The two sides of the proxy on different threads */
 	  if (ps->po.tx_fifo->master_thread_index != s->thread_index)
 	    {
@@ -357,7 +355,10 @@ proxy_try_delete_session (session_t * s, u8 is_active_open)
 	      proxy_session_postponed_free (ps);
 	    }
 	  else
-	    proxy_session_free (ps);
+	    {
+	      ASSERT (s->rx_fifo->refcnt == 1);
+	      proxy_session_free (ps);
+	    }
 	}
     }
   else