From: Benoît Ganne <bganne@cisco.com>
Date: Wed, 16 Oct 2019 13:11:22 +0000 (+0200)
Subject: session: fix use-after-free
X-Git-Tag: v20.05-rc0~619
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=94d2da0b294b0084dd97217e79de18842f09356b;p=vpp.git

session: fix use-after-free

Type: fix

Change-Id: Ie63b80db56febc8a16bafcdd5399b2f92b6aa437
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/vnet/session/mma_template.c b/src/vnet/session/mma_template.c
index e66f2919720..ae730e5dbea 100644
--- a/src/vnet/session/mma_template.c
+++ b/src/vnet/session/mma_template.c
@@ -60,8 +60,8 @@ RTT (mma_rule) * RT (mma_rules_table_rule_alloc) (RTT (mma_rules_table) * srt)
 RTT (mma_rule) *
 RT (mma_rule_free) (RTT (mma_rules_table) * srt, RTT (mma_rule) * rule)
 {
-  pool_put (srt->rules, rule);
   clib_memset (rule, 0xfa, sizeof (*rule));
+  pool_put (srt->rules, rule);
   return rule;
 }