From: Vratko Polak <vrpolak@cisco.com>
Date: Wed, 27 Feb 2019 11:36:09 +0000 (+0100)
Subject: Migrate CSIT pylint job to tox
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=9c6b8f8bdbe90c419a5a66ec50c03d582860f4e4;p=ci-management.git

Migrate CSIT pylint job to tox

Change-Id: If58167539dff7edc31387388215f3112b48ab115
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
---

diff --git a/jjb/csit/csit-vpp-pylint.yaml b/jjb/csit/csit-tox.yaml
similarity index 67%
rename from jjb/csit/csit-vpp-pylint.yaml
rename to jjb/csit/csit-tox.yaml
index 0a4f4556e..cb7f648d3 100644
--- a/jjb/csit/csit-vpp-pylint.yaml
+++ b/jjb/csit/csit-tox.yaml
@@ -3,7 +3,7 @@
     name: csit-validate
 
     jobs:
-      - 'csit-validate-pylint-{stream}'
+      - 'csit-verify-tox-{stream}'
 
     project: 'csit'
     branch: 'master'
@@ -14,10 +14,10 @@
           branch: 'rls1901'
 
 - job-template:
-    name: 'csit-validate-pylint-{stream}'
+    name: 'csit-verify-tox-{stream}'
 
     project-type: freestyle
-    node: ubuntu1604-basebuild-4c-4g
+    node: ubuntu1804-us
     concurrent: true
 
     build-discarder:
@@ -31,6 +31,7 @@
           project: '{project}'
       - gerrit-parameter:
           branch: '{branch}'
+      - gerrit-refspec-parameter
 
     scm:
       - gerrit-trigger-scm:
@@ -48,19 +49,15 @@
           branch: '{branch}'
 
     builders:
-      # yamllint disable-line rule:line-length
-      # This is where we will need to insert a step with a script that pulls all the
-      # yamllint disable-line rule:line-length
-      # allocated IP addresses and injecting as vars into the env. (see Opendaylight script: include-raw-integration-get-slave-addresses.sh
-      # yamllint enable rule:line-length
-      # See jjb/integration from ODL
       - shell:
-          !include-raw-escape: include-raw-csit-pylint.sh
+          ./resources/libraries/bash/entry/tox.sh
 
     publishers:
       - archive-artifacts:
-          artifacts: 'pylint.log'
+          artifacts: '*.log'
           latest-only: false
+      # TODO: Remove this when a voting pylint difference checker
+      # with nice enough output is implemented.
       - violations:
           pylint:
             min: 10
diff --git a/jjb/csit/include-raw-csit-pylint.sh b/jjb/csit/include-raw-csit-pylint.sh
deleted file mode 100644
index 2987e5e25..000000000
--- a/jjb/csit/include-raw-csit-pylint.sh
+++ /dev/null
@@ -1,17 +0,0 @@
-#!/bin/bash
-
-set -x
-
-# Re-create virtual environment
-rm -rf env || true
-virtualenv env
-. env/bin/activate
-
-# Install requirements, so all CSIT python dependencies are met
-pip install -r requirements.txt
-pip install pylint==1.5.4
-
-# Run pylint, but hide its' return value until python warnings are cleared
-PYTHONPATH=`pwd` pylint --rcfile=pylint.cfg resources/ > pylint.log || true
-
-# vim: ts=4 ts=4 sts=4 et :