From: Benoît Ganne <bganne@cisco.com>
Date: Wed, 29 Sep 2021 16:51:31 +0000 (+0200)
Subject: ikev2: do not send IDi on responder AUTH
X-Git-Tag: v22.06-rc0~438
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=9d22cb363e95d679f58481eb767eed81a58e8237;p=vpp.git

ikev2: do not send IDi on responder AUTH

The IDi is not mentioned in the RFC for the responder AUTH message, and
it confuses some IKE implementations.

Type: fix

Change-Id: I2bcefa1efd315412a6f5fa592668d4e0da510264
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/plugins/ikev2/ikev2.c b/src/plugins/ikev2/ikev2.c
index 3d95da315f1..fe4c154e9c9 100644
--- a/src/plugins/ikev2/ikev2.c
+++ b/src/plugins/ikev2/ikev2.c
@@ -2385,7 +2385,6 @@ ikev2_generate_message (vlib_buffer_t *b, ikev2_sa_t *sa, ike_header_t *ike,
       if (sa->state == IKEV2_STATE_AUTHENTICATED)
 	{
 	  ikev2_payload_add_id (chain, &sa->r_id, IKEV2_PAYLOAD_IDR);
-	  ikev2_payload_add_id (chain, &sa->i_id, IKEV2_PAYLOAD_IDI);
 	  ikev2_payload_add_auth (chain, &sa->r_auth);
 	  ikev2_payload_add_sa (chain, sa->childs[0].r_proposals);
 	  ikev2_payload_add_ts (chain, sa->childs[0].tsi, IKEV2_PAYLOAD_TSI);