From: Florin Coras <fcoras@cisco.com>
Date: Wed, 8 Jan 2020 23:30:15 +0000 (+0000)
Subject: tcp: fix persist assert
X-Git-Tag: v20.05-rc0~26
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=a6696719cb9fcd8ab54a5007e91dac6aeffe4e70;p=vpp.git

tcp: fix persist assert

Type: fix

Persist and retransmit can pop at the same time.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia9530645cc84c83a881a75d7b4627197dc50ed29
---

diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c
index 05db72770f5..631b33ae819 100644
--- a/src/vnet/tcp/tcp_output.c
+++ b/src/vnet/tcp/tcp_output.c
@@ -1688,10 +1688,7 @@ tcp_timer_persist_handler (u32 index, u32 thread_index)
     }
 
   if (available_bytes <= offset)
-    {
-      ASSERT (tcp_timer_is_active (tc, TCP_TIMER_RETRANSMIT));
-      return;
-    }
+    return;
 
   /* Increment RTO backoff */
   tc->rto_boff += 1;