From: Klement Sekera <ksekera@cisco.com>
Date: Tue, 16 Nov 2021 11:19:26 +0000 (+0100)
Subject: misc: vppctl - fix coverity warning
X-Git-Tag: v22.10-rc0~450
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=aa9903cabfd44ed9c88d1f624a39096ff7fee37f;p=vpp.git

misc: vppctl - fix coverity warning

Check that provided path fits into defined buffer. Don't write too many
bytes to avoid having an unterminated string.

Type: fix
Fixes: 31f192434660
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I1ea8b6d6a3474c032e542b6980ed14bac72093a8
---

diff --git a/src/vpp/app/vppctl.c b/src/vpp/app/vppctl.c
index c9f33abf7ab..de5572d6bfa 100644
--- a/src/vpp/app/vppctl.c
+++ b/src/vpp/app/vppctl.c
@@ -192,6 +192,13 @@ main (int argc, char *argv[])
 
   struct sockaddr_un saddr = { 0 };
   saddr.sun_family = AF_UNIX;
+
+  if (strlen (sock_fname) > sizeof (saddr.sun_path) - 1)
+    {
+      perror ("socket path too long");
+      exit (1);
+    }
+
   strncpy (saddr.sun_path, sock_fname, sizeof (saddr.sun_path) - 1);
 
   sock_fd = socket (AF_UNIX, SOCK_STREAM, 0);