From: Filip Tehlar <ftehlar@cisco.com>
Date: Fri, 3 Jun 2022 12:21:16 +0000 (+0000)
Subject: session: fix double free in CLI
X-Git-Tag: v23.02-rc0~200
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=af21b2e6994893e97ad0fef52ca154c69a4a09cb;p=vpp.git

session: fix double free in CLI

Type: fix

Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Change-Id: I646ac946d0b07929dfdd1966a4f4a3b697768040
---

diff --git a/src/vnet/session/session_cli.c b/src/vnet/session/session_cli.c
index da2df331b44..344937c684a 100644
--- a/src/vnet/session/session_cli.c
+++ b/src/vnet/session/session_cli.c
@@ -841,7 +841,6 @@ session_enable_disable_fn (vlib_main_t * vm, unformat_input_t * input,
 			   vlib_cli_command_t * cmd)
 {
   u8 is_en = 2;
-  clib_error_t *error;
 
   while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
     {
@@ -850,12 +849,8 @@ session_enable_disable_fn (vlib_main_t * vm, unformat_input_t * input,
       else if (unformat (input, "disable"))
 	is_en = 0;
       else
-	{
-	  error = clib_error_return (0, "unknown input `%U'",
-				     format_unformat_error, input);
-	  unformat_free (input);
-	  return error;
-	}
+	return clib_error_return (0, "unknown input `%U'",
+				  format_unformat_error, input);
     }
 
   if (is_en > 1)