From: Paul Atkins <patkins@graphiant.com>
Date: Tue, 23 Nov 2021 10:51:07 +0000 (+0000)
Subject: ipfix-export: don't check the result of pool_get
X-Git-Tag: v22.06-rc0~177
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=b779ca9324a6bd2dd605e578b3ca9a4bb90bfa03;p=vpp.git

ipfix-export: don't check the result of pool_get

The code to check the exp is set after the call to pool_get()
is marked as unreachable in coverity. This is becasue if it
fails in pool_get then the it panics. Remove the unreachable code.

Type: fix
Signed-off-by: Paul Atkins <patkins@graphiant.com>
Change-Id: Iabb51b6b6788b6c12ef37c28dde2118c798de831
---

diff --git a/src/vnet/ipfix-export/flow_api.c b/src/vnet/ipfix-export/flow_api.c
index 4a9b525ac67..0b287335bbf 100644
--- a/src/vnet/ipfix-export/flow_api.c
+++ b/src/vnet/ipfix-export/flow_api.c
@@ -107,8 +107,6 @@ vl_api_set_ipfix_exporter_t_internal (
 	      if (pool_elts (frm->exporters) >= IPFIX_EXPORTERS_MAX)
 		return VNET_API_ERROR_INVALID_VALUE;
 	      pool_get (frm->exporters, exp);
-	      if (!exp)
-		return VNET_API_ERROR_INVALID_VALUE;
 	    }
 	}
       else