From: Benoît Ganne <bganne@cisco.com>
Date: Wed, 10 Jul 2019 15:01:09 +0000 (+0200)
Subject: syslog: fix syslog structured data formatting
X-Git-Tag: v20.01-rc0~200
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=bbe6d110a10d64e5bde21c4b839642acfbf91cbd;hp=9e4946b324a8480b35c861e96199881b314ea825;p=vpp.git

syslog: fix syslog structured data formatting

syslog structured data are stored as vectors not null-terminated
C-strings. Use '%v' instead of '%s'.

Type: fix
Fixes: b4515b4be4

Change-Id: Iba224f271c832daca90d4bbccfef45d0f563fe60
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/MAINTAINERS b/MAINTAINERS
index d9109ed48b0..d74398fb9c6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -234,6 +234,11 @@ F:	src/vnet/tls
 F:	src/plugins/tlsopenssl
 F:	src/plugins/tlsmbedtls
 
+VNET SYSLOG
+I:	syslog
+M:	Matus Fabian <matfabia@cisco.com>
+F:	src/vnet/syslog
+
 Plugin - Access Control List (ACL) Based Forwarding
 I:	abf
 M:	Neale Ranns <nranns@cisco.com>
diff --git a/src/vnet/syslog/syslog.c b/src/vnet/syslog/syslog.c
index 462c5deeecd..f104691a614 100644
--- a/src/vnet/syslog/syslog.c
+++ b/src/vnet/syslog/syslog.c
@@ -72,7 +72,7 @@ format_syslog_structured_data (u8 * s, va_list * args)
   if (vec_len (sds))
     {
       for (i = 0; i < vec_len (sds); i++)
-	s = format (s, "[%s]", sds[i]);
+	s = format (s, "[%v]", sds[i]);
     }
   /* if zero structured data elemts field must contain NILVALUE */
   else