From: Florin Coras <fcoras@cisco.com>
Date: Thu, 12 Oct 2023 19:39:15 +0000 (-0700)
Subject: session: fix duplicate rx events
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=bfa5a1a7fa59e5cf6dbbe0702cf440d71ced6a89;p=vpp.git

session: fix duplicate rx events

Be less aggressive with rx events on connect/accept notification.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie93a08c7eef69383bf0301a163fd2131dd51372a
(cherry picked from commit 054aa8c2f2681e3a4a4af02d9119fb6eaa5dbad6)
---

diff --git a/src/vnet/session/session_input.c b/src/vnet/session/session_input.c
index efc4f542007..42d71819b0a 100644
--- a/src/vnet/session/session_input.c
+++ b/src/vnet/session/session_input.c
@@ -158,11 +158,6 @@ app_worker_flush_events_inline (app_worker_t *app_wrk, u32 thread_index,
 	    }
 	  if (is_builtin)
 	    {
-	      if (s->flags & SESSION_F_RX_EVT)
-		{
-		  s->flags &= ~SESSION_F_RX_EVT;
-		  app->cb_fns.builtin_app_rx_callback (s);
-		}
 	      if (old_state >= SESSION_STATE_TRANSPORT_CLOSING)
 		{
 		  session_set_state (s, old_state);
@@ -189,11 +184,6 @@ app_worker_flush_events_inline (app_worker_t *app_wrk, u32 thread_index,
 	      s->app_wrk_index = SESSION_INVALID_INDEX;
 	      break;
 	    }
-	  if (s->flags & SESSION_F_RX_EVT)
-	    {
-	      s->flags &= ~SESSION_F_RX_EVT;
-	      app->cb_fns.builtin_app_rx_callback (s);
-	    }
 	  if (old_state >= SESSION_STATE_TRANSPORT_CLOSING)
 	    {
 	      session_set_state (s, old_state);