From: Damjan Marion <damarion@cisco.com>
Date: Fri, 28 Jul 2023 10:57:15 +0000 (+0200)
Subject: vlib: fix coverity issue in vlib_node_set_interrupt_pending
X-Git-Tag: v24.02-rc0~109
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=c5c0d0cf8ab30b29ab72e0933d32259e32d9c95a;p=vpp.git

vlib: fix coverity issue in vlib_node_set_interrupt_pending

Type: fix
Fixes: cc8249c
Change-Id: Iebfbbd1e00782c4097cc840460b5177d18921131
Signed-off-by: Damjan Marion <damarion@cisco.com>
---

diff --git a/src/vlib/node_funcs.h b/src/vlib/node_funcs.h
index 66f079c0547..37f7538d70a 100644
--- a/src/vlib/node_funcs.h
+++ b/src/vlib/node_funcs.h
@@ -252,14 +252,17 @@ vlib_node_set_interrupt_pending (vlib_main_t *vm, u32 node_index)
 {
   vlib_node_main_t *nm = &vm->node_main;
   vlib_node_t *n = vec_elt (nm->nodes, node_index);
-  void *interrupts;
+  void *interrupts = 0;
 
   if (n->type == VLIB_NODE_TYPE_INPUT)
     interrupts = nm->input_node_interrupts;
   else if (n->type == VLIB_NODE_TYPE_PRE_INPUT)
     interrupts = nm->pre_input_node_interrupts;
   else
-    ASSERT (0);
+    {
+      ASSERT (0);
+      return;
+    }
 
   if (vm != vlib_get_main ())
     clib_interrupt_set_atomic (interrupts, n->runtime_index);