From: Benoît Ganne <bganne@cisco.com>
Date: Fri, 26 Apr 2019 09:09:49 +0000 (+0200)
Subject: elf: fix memcmp() overflow
X-Git-Tag: v20.01-rc0~709
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=c6eb5bc967d3d70016b4e4e182b3d68b1e558f60;p=vpp.git

elf: fix memcmp() overflow

name can be (and will be) smaller than section_name_start. Both name and
section_name_start are NULL-terminated so we can use strcmp.

Change-Id: Iec414810109f9267de20c25c0fe601df35daf89e
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/vppinfra/elf_clib.c b/src/vppinfra/elf_clib.c
index 7bb72ee3e3f..2bc05e1d8d4 100644
--- a/src/vppinfra/elf_clib.c
+++ b/src/vppinfra/elf_clib.c
@@ -153,7 +153,7 @@ clib_elf_parse_file (clib_elf_main_t * cem,
       clib_elf_section_bounds_t *b;
 
       /* Section name must begin with CLIB_ELF_SECTION key. */
-      if (memcmp (name, section_name_start, section_name_start_len))
+      if (strcmp ((char *) name, section_name_start))
 	continue;
 
       name += section_name_start_len;