From: Florin Coras <fcoras@cisco.com>
Date: Tue, 13 Oct 2020 02:03:52 +0000 (-0700)
Subject: tcp: fix listener trace coverity warning
X-Git-Tag: v21.06-rc0~366
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=d1b423c924202950acf36fea1d221bf1dda9b39d;p=vpp.git

tcp: fix listener trace coverity warning

Type: fix

Change-Id: I75c0bd862260e188f625271c3bd545a7ab37af5d
Signed-off-by: Florin Coras <fcoras@cisco.com>
---

diff --git a/src/vnet/tcp/tcp_input.c b/src/vnet/tcp/tcp_input.c
index 948383b4789..91a4fcacfde 100644
--- a/src/vnet/tcp/tcp_input.c
+++ b/src/vnet/tcp/tcp_input.c
@@ -2650,12 +2650,8 @@ tcp46_listen_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
 
       if (PREDICT_FALSE (b->flags & VLIB_BUFFER_IS_TRACED))
 	{
-	  tcp_rx_trace_t *t;
-	  t = vlib_add_trace (vm, node, b, sizeof (*t));
-	  clib_memcpy_fast (&t->tcp_header, tcp_buffer_hdr (b),
-			    sizeof (t->tcp_header));
-	  clib_memcpy_fast (&t->tcp_connection, lc,
-			    sizeof (t->tcp_connection));
+	  tcp_rx_trace_t *t = vlib_add_trace (vm, node, b, sizeof (*t));
+	  tcp_set_rx_trace_data (t, lc, tcp_buffer_hdr (b), b, is_ip4);
 	}
 
       n_syns += (error == TCP_ERROR_NONE);