From: Florin Coras <fcoras@cisco.com>
Date: Tue, 23 Feb 2021 20:03:03 +0000 (-0800)
Subject: vcl: fix coverity warning
X-Git-Tag: v21.10-rc0~483
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=d77325c0c43f270a1717d4d5b5acb94cdf674c1f;p=vpp.git

vcl: fix coverity warning

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id9f922eafe4a68661d2858d72fc548a372e9596a
---

diff --git a/src/vcl/vppcom.c b/src/vcl/vppcom.c
index a439d2550a1..cc4464b162e 100644
--- a/src/vcl/vppcom.c
+++ b/src/vcl/vppcom.c
@@ -3637,16 +3637,18 @@ vppcom_session_attr (uint32_t session_handle, uint32_t op,
       break;
 
     case VPPCOM_ATTR_GET_DOMAIN:
-      if (buffer && buflen && (*buflen >= sizeof (int)))
+      if (!(buffer && buflen && (*buflen >= sizeof (int))))
 	{
-	  if (session->transport.is_ip4)
-	    *(int *) buffer = AF_INET;
-	  else
-	    *(int *) buffer = AF_INET6;
-	  *buflen = sizeof (int);
+	  rv = VPPCOM_EINVAL;
+	  break;
 	}
+
+      if (session->transport.is_ip4)
+	*(int *) buffer = AF_INET;
       else
-	rv = VPPCOM_EINVAL;
+	*(int *) buffer = AF_INET6;
+      *buflen = sizeof (int);
+
       VDBG (2, "VPPCOM_ATTR_GET_DOMAIN: %d, buflen %u", *(int *) buffer,
 	    *buflen);
       break;