From: Andrew Yourtchenko <ayourtch@gmail.com>
Date: Thu, 20 Sep 2018 13:36:51 +0000 (+0200)
Subject: bihash template: avoid memory leak upon rehash
X-Git-Tag: v18.10-rc1~149
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=df32bc4dee0cfe514a8fca5085ea555211521387;p=vpp.git

bihash template: avoid memory leak upon rehash

Call the BV (value_free) when we have performed the rehash
and thus no longer need the memory that old value for the
bucket refers to.

Change-Id: Ibb82174fc8002aeb3e1a6c8d1f90293d73bc45d8
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
---

diff --git a/src/vppinfra/bihash_template.c b/src/vppinfra/bihash_template.c
index 2571c47e64c..752597ebbd5 100644
--- a/src/vppinfra/bihash_template.c
+++ b/src/vppinfra/bihash_template.c
@@ -627,6 +627,9 @@ expand_ok:
   tmp_b.lock = 0;
   CLIB_MEMORY_BARRIER ();
   b->as_u64 = tmp_b.as_u64;
+  /* free the old bucket */
+  v = BV (clib_bihash_get_value) (h, h->saved_bucket.offset);
+  BV (value_free) (h, v, h->saved_bucket.log2_pages);
   BV (clib_bihash_alloc_unlock) (h);
   return (0);
 }