From: Steven Luong <sluong@cisco.com>
Date: Thu, 6 Jan 2022 21:02:00 +0000 (-0800)
Subject: bonding: memory leak on parsing bad CLI command
X-Git-Tag: v22.06-rc0~51
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=ed999e3b8159eb5b584354af95686a84fb012e05;p=vpp.git

bonding: memory leak on parsing bad CLI command

When parsing bad "create bond" command, we should call unformat_free
prior to return

Type: fix
Fixes: 9cd2d7a5a4fafadb65d772c48109d55d1e19d425

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I8f20a0e7f29de670e09633880d0aa50a51444e11
---

diff --git a/src/vnet/bonding/cli.c b/src/vnet/bonding/cli.c
index 62bbbdae75c..d20c68606d8 100644
--- a/src/vnet/bonding/cli.c
+++ b/src/vnet/bonding/cli.c
@@ -510,12 +510,18 @@ bond_create_command_fn (vlib_main_t * vm, unformat_input_t * input,
 	  if (args.mode == BOND_MODE_LACP)
 	    args.numa_only = 1;
 	  else
-	    return clib_error_return (0,
-				      "Only lacp mode supports numa-only so far!");
+	    {
+	      unformat_free (line_input);
+	      return clib_error_return (
+		0, "Only lacp mode supports numa-only so far!");
+	    }
 	}
       else
-	return clib_error_return (0, "unknown input `%U'",
-				  format_unformat_error, input);
+	{
+	  unformat_free (line_input);
+	  return clib_error_return (0, "unknown input `%U'",
+				    format_unformat_error, input);
+	}
     }
   unformat_free (line_input);