From: Dave Barach <dave@barachs.net>
Date: Wed, 11 Jul 2018 11:01:25 +0000 (-0400)
Subject: VPP-1338: fix coverity warning in mactime plugin
X-Git-Tag: v18.07-rc1~25
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=f46d8f8d3fa1e0cefbc4c70645f2121b14662d4f;p=vpp.git

VPP-1338: fix coverity warning in mactime plugin

Add missing VALIDATE_SW_IF_INDEX macro / check.

Net of this fix, a spurious warning will probably recur. Coverity will
complain that sw_if_index is tainted. Please dismiss the warning.

Change-Id: Iec31ce1d86f742e197e63b0c5d474cd5e496ee5f
Signed-off-by: Dave Barach <dave@barachs.net>
---

diff --git a/src/plugins/mactime/mactime.c b/src/plugins/mactime/mactime.c
index 06dda537a2f..c5c6b8b9f2c 100644
--- a/src/plugins/mactime/mactime.c
+++ b/src/plugins/mactime/mactime.c
@@ -177,9 +177,11 @@ static void vl_api_mactime_enable_disable_t_handler
   mactime_main_t *mm = &mactime_main;
   int rv;
 
+  VALIDATE_SW_IF_INDEX (mp);
+
   rv = mactime_enable_disable (mm, ntohl (mp->sw_if_index),
 			       (int) (mp->enable_disable));
-
+  BAD_SW_IF_INDEX_LABEL;
   REPLY_MACRO (VL_API_MACTIME_ENABLE_DISABLE_REPLY);
 }