From: Florin Coras <fcoras@cisco.com>
Date: Thu, 2 Jul 2020 21:52:34 +0000 (-0700)
Subject: tcp: fix coverity warning
X-Git-Tag: v21.01-rc0~223
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=fbb846cfa1f95d57159f9ad6cc429f6d9d0b8696;p=vpp.git

tcp: fix coverity warning

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I60828bc084b9adbb925c306d26060412c410c516
---

diff --git a/src/vnet/tcp/tcp_cli.c b/src/vnet/tcp/tcp_cli.c
index ada2ac0b4d5..b76b40474a6 100644
--- a/src/vnet/tcp/tcp_cli.c
+++ b/src/vnet/tcp/tcp_cli.c
@@ -907,7 +907,7 @@ tcp_show_half_open (vlib_main_t * vm, u32 start, u32 end, u8 verbose)
   int max_index, i;
 
   n_elts = pool_elts (tm->half_open_connections);
-  max_index = pool_len (tm->half_open_connections) - 1;
+  max_index = clib_max (pool_len (tm->half_open_connections), 1) - 1;
   if (verbose && end == ~0 && n_elts > 50)
     {
       vlib_cli_output (vm, "Too many connections, use range <start> <end>");
@@ -966,7 +966,7 @@ show_tcp_half_open_fn (vlib_main_t * vm, unformat_input_t * input,
     {
       if (unformat (line_input, "range %u %u", &start, &end))
 	;
-      else if (unformat (line_input, "verbose %d"), &verbose)
+      else if (unformat (line_input, "verbose %d", &verbose))
 	;
       else if (unformat (line_input, "verbose"))
 	verbose = 1;