From: Mohsin Kazmi Date: Mon, 11 Oct 2021 15:43:15 +0000 (+0000) Subject: memif: fix the memif crash when slave disconnect X-Git-Tag: v22.06-rc0~416 X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=fcef34dd1cf2e356cc8909e16dc7fa93fffbff2b;p=vpp.git memif: fix the memif crash when slave disconnect Type: fix Fixes: 3effb4e63068 ("memif: integrate with new tx infra") memif is recently integrated with new tx infra. But it introduces a crash when slave disconnect from master but interface is not deleted. Disconnect routine was missing unregister of all tx queues. This patch fixes it. Signed-off-by: Mohsin Kazmi Change-Id: I81c59cc1a03561248ec8595d5e3caa54f421833e --- diff --git a/src/plugins/memif/memif.c b/src/plugins/memif/memif.c index 55d9b84fd4c..886721aef75 100644 --- a/src/plugins/memif/memif.c +++ b/src/plugins/memif/memif.c @@ -147,7 +147,6 @@ memif_disconnect (memif_if_t * mif, clib_error_t * err) } } vnet_hw_if_unregister_all_rx_queues (vnm, mif->hw_if_index); - vnet_hw_if_update_runtime_data (vnm, mif->hw_if_index); /* *INDENT-OFF* */ vec_foreach_index (i, mif->tx_queues) @@ -163,6 +162,8 @@ memif_disconnect (memif_if_t * mif, clib_error_t * err) } mq->ring = 0; } + vnet_hw_if_unregister_all_tx_queues (vnm, mif->hw_if_index); + vnet_hw_if_update_runtime_data (vnm, mif->hw_if_index); /* free tx and rx queues */ vec_foreach (mq, mif->rx_queues)