From: Alexey Stratulat <a.stratulat@ideco.ru>
Date: Mon, 20 Jan 2025 11:34:25 +0000 (+0700)
Subject: vcl: segfault correction in vcl_session_connected_handler
X-Git-Tag: v25.06-rc0~11
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F02%2F42202%2F4;p=vpp.git

vcl: segfault correction in vcl_session_connected_handler

Svace found a bug related to the fact that the
vcl_segment_attach_session function is passed
a pointer to a session, which is null, because of this,
when using it, a segmentation error will occur inside the function.

This issue was fixed.

Type: fix

Change-Id: Icc68ced80611bb709c9fa7868816f003373077d4
Signed-off-by: Alexey Stratulat <a.stratulat@ideco.ru>
---

diff --git a/src/vcl/vppcom.c b/src/vcl/vppcom.c
index 0b2141614ee..e1eba2993ca 100644
--- a/src/vcl/vppcom.c
+++ b/src/vcl/vppcom.c
@@ -413,7 +413,7 @@ vcl_session_connected_handler (vcl_worker_t * wrk,
       };
       vcl_segment_attach_session (
 	mp->segment_handle, mp->server_rx_fifo, mp->server_tx_fifo,
-	mp->vpp_event_queue_address, mp->mq_index, 0, session);
+	mp->vpp_event_queue_address, mp->mq_index, 0, &tmp_session);
       if (tmp_session.vpp_evt_q)
 	vcl_send_session_disconnect (wrk, &tmp_session);
       return VCL_INVALID_SESSION_INDEX;