From: Benoît Ganne <bganne@cisco.com>
Date: Wed, 11 Sep 2019 14:43:44 +0000 (+0200)
Subject: api: fix use-after-free
X-Git-Tag: v20.05-rc0~752
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F08%2F22408%2F3;p=vpp.git

api: fix use-after-free

Type: fix

Change-Id: I2a599c22d5770587fdd419e5d212c8527054d2e9
Signed-off-by: Benoît Ganne <bganne@cisco.com>
---

diff --git a/src/vlibmemory/memory_api.c b/src/vlibmemory/memory_api.c
index b87aa76b2d0..34fd9563b73 100644
--- a/src/vlibmemory/memory_api.c
+++ b/src/vlibmemory/memory_api.c
@@ -319,6 +319,9 @@ vl_api_memclnt_delete_t_handler (vl_api_memclnt_delete_t * mp)
 	    }
 	}
 
+      /* No dangling references, please */
+      *regpp = 0;
+
       /* For horizontal scaling, add a hash table... */
       for (i = 0; i < vec_len (am->vlib_private_rps); i++)
 	{
@@ -347,9 +350,6 @@ vl_api_memclnt_delete_t_handler (vl_api_memclnt_delete_t * mp)
 	    }
 	}
 
-      /* No dangling references, please */
-      *regpp = 0;
-
       if (private_registration == 0)
 	{
 	  pool_put_index (am->vl_clients,