From: Andrew Yourtchenko <ayourtch@gmail.com>
Date: Thu, 15 Sep 2022 11:46:30 +0000 (+0000)
Subject: prom: fix coverity 277312, 277317
X-Git-Tag: v23.02-rc0~22
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F28%2F37128%2F1;p=vpp.git

prom: fix coverity 277312, 277317

If one attempts to add a pattern with zero length, first time
it will succeed, and the second time it will cause an invalid memcmp call.

Solution: do not allow to add zero-length patterns.

Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: Ic08e021486153be605a4b12a2fe4422307bf68d2
---

diff --git a/src/plugins/prom/prom.c b/src/plugins/prom/prom.c
index 6db50204d65..3e0fa3b408d 100644
--- a/src/plugins/prom/prom.c
+++ b/src/plugins/prom/prom.c
@@ -305,6 +305,8 @@ prom_stat_patterns_add (u8 **patterns)
     {
       found = 0;
       len = vec_len (*pattern);
+      if (len == 0)
+	continue;
       vec_foreach (existing, pm->stats_patterns)
 	{
 	  if (vec_len (*existing) != len)