From: Florin Coras <fcoras@cisco.com>
Date: Tue, 25 Feb 2020 22:28:27 +0000 (+0000)
Subject: svm: fix coverity warnings
X-Git-Tag: v20.09-rc0~485
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F30%2F25430%2F3;p=vpp.git

svm: fix coverity warnings

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2d5cb7cccb67a3193ce5a25323e70bc05737e023
---

diff --git a/src/svm/fifo_segment.c b/src/svm/fifo_segment.c
index ec6f082398e..e19113fd449 100644
--- a/src/svm/fifo_segment.c
+++ b/src/svm/fifo_segment.c
@@ -75,7 +75,6 @@ static inline uword
 fsh_n_cached_bytes (fifo_segment_header_t * fsh)
 {
   uword n_cached = clib_atomic_load_relax_n (&fsh->n_cached_bytes);
-  ASSERT (n_cached >= 0);
   return n_cached;
 }
 
diff --git a/src/vnet/session/segment_manager.c b/src/vnet/session/segment_manager.c
index db38097602c..cbd44432e8a 100644
--- a/src/vnet/session/segment_manager.c
+++ b/src/vnet/session/segment_manager.c
@@ -981,8 +981,7 @@ void
 segment_manager_set_watermarks (segment_manager_t * sm,
 				u8 high_watermark, u8 low_watermark)
 {
-  ASSERT (high_watermark >= 0 && high_watermark <= 100 &&
-	  low_watermark >= 0 && low_watermark <= 100 &&
+  ASSERT (high_watermark <= 100 && low_watermark <= 100 &&
 	  low_watermark <= high_watermark);
 
   sm->high_watermark = high_watermark;