From: Marek Gradzki <mgradzki@cisco.com>
Date: Thu, 7 Sep 2017 11:06:55 +0000 (+0200)
Subject: Fix error-handling issues found by Sonar
X-Git-Tag: v1.17.10-RC1~7
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F35%2F8335%2F1;p=hc2vpp.git

Fix error-handling issues found by Sonar

Change-Id: Ic370f72c16beaf56003021a6a89f751de8b744b8
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
---

diff --git a/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java b/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java
index 2e260e108..af9e5dadd 100755
--- a/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java
+++ b/ioam/impl/src/main/java/io/fd/hc2vpp/vppioam/impl/config/IoamTraceWriterCustomizer.java
@@ -93,7 +93,7 @@ public class IoamTraceWriterCustomizer extends FutureJVppIoamtraceCustomizer
     }
 
     public TraceProfileAddReply addTraceConfig(TraceConfig traceConfig,
-            final InstanceIdentifier<TraceConfig> id) throws Exception {
+            final InstanceIdentifier<TraceConfig> id) throws WriteFailedException {
 
         TraceProfileAdd traceProfileAdd = new TraceProfileAdd();
         traceProfileAdd.traceType = traceConfig.getTraceType().byteValue(); //trace type
@@ -110,7 +110,7 @@ public class IoamTraceWriterCustomizer extends FutureJVppIoamtraceCustomizer
     }
 
     public TraceProfileDelReply deleteTraceConfig(TraceConfig dataBefore,
-                                                  final InstanceIdentifier<TraceConfig> id) throws Exception {
+                                                  final InstanceIdentifier<TraceConfig> id) throws WriteFailedException {
         TraceProfileDel del = new TraceProfileDel();
 
         /* Write to VPP */
diff --git a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java
index 02f89d9f8..69ef7f3ab 100644
--- a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java
+++ b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv4Translator.java
@@ -116,7 +116,7 @@ public interface Ipv4Translator extends ByteDataTranslator {
                             String.valueOf(prefix)));
         } catch (UnknownHostException e) {
             throw new IllegalArgumentException(
-                    "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]");
+                    "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]", e);
         }
     }
 }
diff --git a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java
index 457c172c1..d2f046302 100644
--- a/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java
+++ b/vpp-common/vpp-translate-utils/src/main/java/io/fd/hc2vpp/common/translate/util/Ipv6Translator.java
@@ -135,7 +135,7 @@ public interface Ipv6Translator extends ByteDataTranslator {
                             String.valueOf(prefix)));
         } catch (UnknownHostException e) {
             throw new IllegalArgumentException(
-                    "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]");
+                    "Cannot create prefix for address[" + Arrays.toString(address) + "],prefix[" + prefix + "]", e);
         }
     }