From: Tom Seidenberg <tseidenb@cisco.com>
Date: Fri, 15 Mar 2019 14:15:26 +0000 (-0400)
Subject: Fix bihash bucket double unlock.
X-Git-Tag: v19.04-rc1~203
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F36%2F18336%2F4;p=vpp.git

Fix bihash bucket double unlock.

Change-Id: Icc9bef32d1bb2b8f277598c50c69343c81f22cd2
Signed-off-by: Tom Seidenberg <tseidenb@cisco.com>
---

diff --git a/src/vppinfra/bihash_template.c b/src/vppinfra/bihash_template.c
index 698053867a4..6e910febce1 100644
--- a/src/vppinfra/bihash_template.c
+++ b/src/vppinfra/bihash_template.c
@@ -441,8 +441,7 @@ static inline int BV (clib_bihash_add_del_inline)
       tmp_b.refcnt = 1;
       CLIB_MEMORY_BARRIER ();
 
-      b->as_u64 = tmp_b.as_u64;
-      BV (clib_bihash_unlock_bucket) (b);
+      b->as_u64 = tmp_b.as_u64;	/* unlocks the bucket */
       return (0);
     }