From: Steven Luong <sluong@cisco.com>
Date: Sat, 29 Jun 2024 23:26:54 +0000 (-0700)
Subject: unittest: coverity woe
X-Git-Tag: v25.02-rc0~158
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F41%2F41241%2F1;p=vpp.git

unittest: coverity woe

check return value after strstr()

Type: fix

Change-Id: Ib6eb82b6a52c7e08785f6deb73e6cc7a10e7f61b
Signed-off-by: Steven Luong <sluong@cisco.com>
---

diff --git a/src/plugins/unittest/session_test.c b/src/plugins/unittest/session_test.c
index 33649662e5e..12d000bd46f 100644
--- a/src/plugins/unittest/session_test.c
+++ b/src/plugins/unittest/session_test.c
@@ -2079,11 +2079,14 @@ session_get_memory_usage (void)
   clib_mem_heap_t *heap = clib_mem_get_per_cpu_heap ();
   u8 *s = 0;
   char *ss;
-  f32 used;
+  f32 used = 0.0;
 
   s = format (s, "%U\n", format_clib_mem_heap, heap, 0);
   ss = strstr ((char *) s, "used:");
-  sscanf (ss, "used: %f", &used);
+  if (ss)
+    sscanf (ss, "used: %f", &used);
+  else
+    clib_warning ("substring 'used:' not found from show memory");
   vec_free (s);
   return (used);
 }