From: Florin Coras <fcoras@cisco.com>
Date: Fri, 16 Aug 2019 02:55:03 +0000 (-0700)
Subject: tcp: fix cc algo name parsing
X-Git-Tag: v20.05-rc0~995
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F42%2F21342%2F3;p=vpp.git

tcp: fix cc algo name parsing

Type: fix

The initial config parser passed a pointer to the field algo id field in
tcp main. Because the field is a u8 and it was interpreted as a uword,
it ended up overwrting other tcp configuration fields.

Change-Id: Ie9020051c8fca40e14cf42a9888daa87360e5038
Signed-off-by: Florin Coras <fcoras@cisco.com>
---

diff --git a/src/vnet/tcp/tcp.c b/src/vnet/tcp/tcp.c
index 3b94420e639..327703327aa 100644
--- a/src/vnet/tcp/tcp.c
+++ b/src/vnet/tcp/tcp.c
@@ -1578,7 +1578,7 @@ VLIB_INIT_FUNCTION (tcp_init);
 uword
 unformat_tcp_cc_algo (unformat_input_t * input, va_list * va)
 {
-  uword *result = va_arg (*va, uword *);
+  tcp_cc_algorithm_type_e *result = va_arg (*va, tcp_cc_algorithm_type_e *);
   tcp_main_t *tm = &tcp_main;
   char *cc_algo_name;
   u8 found = 0;