From: Florin Coras Date: Sat, 2 Dec 2023 02:47:45 +0000 (-0800) Subject: session: no segment handle on worker del X-Git-Tag: v24.06-rc0~101 X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F45%2F40045%2F2;p=vpp.git session: no segment handle on worker del Coverity report. Type: fix Signed-off-by: Florin Coras Change-Id: I3ce06634b30688d2a9581b50d462092daa8b4cac --- diff --git a/src/vnet/session/session_api.c b/src/vnet/session/session_api.c index 06edb82bdb3..0574a58c723 100644 --- a/src/vnet/session/session_api.c +++ b/src/vnet/session/session_api.c @@ -709,9 +709,9 @@ done: ((!rv && mp->is_add) ? vec_len (args.segment->name) : 0), ({ rmp->is_add = mp->is_add; rmp->wrk_index = clib_host_to_net_u32 (args.wrk_map_index); - rmp->segment_handle = clib_host_to_net_u64 (args.segment_handle); if (!rv && mp->is_add) { + rmp->segment_handle = clib_host_to_net_u64 (args.segment_handle); rmp->app_event_queue_address = fifo_segment_msg_q_offset ((fifo_segment_t *) args.segment, 0); rmp->n_fds = n_fds; @@ -1473,9 +1473,9 @@ done: rmp->is_add = mp->is_add; rmp->api_client_handle = sapi_handle; rmp->wrk_index = args.wrk_map_index; - rmp->segment_handle = args.segment_handle; if (!rv && mp->is_add) { + rmp->segment_handle = args.segment_handle; /* No segment name and size. This supports only memfds */ rmp->app_event_queue_address = fifo_segment_msg_q_offset ((fifo_segment_t *) args.segment, 0);