From: Marek Gradzki <mgradzki@cisco.com>
Date: Wed, 27 Jun 2018 14:59:59 +0000 (+0200)
Subject: srv6: do not check if SidCustomizer.bindRequest() returns null
X-Git-Tag: v1.18.07-RC1~27
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F47%2F13247%2F2;p=hc2vpp.git

srv6: do not check if SidCustomizer.bindRequest() returns null

Such comparison is allways false.

Change-Id: I39d4caac4146d48c04ecf28b3c9ecf7ae0127949
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
---

diff --git a/srv6/srv6-impl/src/main/java/io/fd/hc2vpp/srv6/write/sid/SidCustomizer.java b/srv6/srv6-impl/src/main/java/io/fd/hc2vpp/srv6/write/sid/SidCustomizer.java
index c63205699..1b3e569c7 100644
--- a/srv6/srv6-impl/src/main/java/io/fd/hc2vpp/srv6/write/sid/SidCustomizer.java
+++ b/srv6/srv6-impl/src/main/java/io/fd/hc2vpp/srv6/write/sid/SidCustomizer.java
@@ -71,10 +71,6 @@ public class SidCustomizer extends FutureJVppCustomizer implements ListWriterCus
         Table vrfTable = getVrfTable(instanceIdentifier, writeContext, locatorIid, locatorOpt);
         LocalSidFunctionRequest request = bindRequest(extractLocPrefix(instanceIdentifier, locatorOpt, localSid),
                 localSid, vrfTable.getTableId().getValue().intValue(), writeContext);
-        if (request == null) {
-            throw new WriteFailedException(instanceIdentifier,
-                    String.format("Cannot create write request for %s", localSid));
-        }
         request.write(instanceIdentifier);
     }
 
@@ -117,11 +113,6 @@ public class SidCustomizer extends FutureJVppCustomizer implements ListWriterCus
         Table vrfTable = getVrfTable(instanceIdentifier, writeContext, locatorIid, locatorOpt);
         LocalSidFunctionRequest request = bindRequest(extractLocPrefix(instanceIdentifier, locatorOpt, localSid),
                 localSid, vrfTable.getTableId().getValue().intValue(), writeContext);
-
-        if (request == null) {
-            throw new WriteFailedException(instanceIdentifier,
-                    String.format("Cannot create delete request for %s", localSid));
-        }
         request.delete(instanceIdentifier);
     }