From: Simon Zhang <yuwei1.zhang@intel.com>
Date: Thu, 28 Mar 2019 08:38:49 +0000 (+0800)
Subject: Add rte_flow_validate to verify the flow before calling rte_flow_create.
X-Git-Tag: v19.01.2~1
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F58%2F18558%2F3;p=vpp.git

Add rte_flow_validate to verify the flow before calling rte_flow_create.

Change-Id: I817580963e38bafcc53cc6502b9c58f567070244
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
---

diff --git a/src/plugins/dpdk/device/flow.c b/src/plugins/dpdk/device/flow.c
index 63f04b8323d..fe52bcb5ac8 100644
--- a/src/plugins/dpdk/device/flow.c
+++ b/src/plugins/dpdk/device/flow.c
@@ -209,12 +209,23 @@ dpdk_flow_add (dpdk_device_t * xd, vnet_flow_t * f, dpdk_flow_entry_t * fe)
   vec_add2 (actions, action, 1);
   action->type = RTE_FLOW_ACTION_TYPE_END;
 
+  rv = rte_flow_validate (xd->device_index, &ingress, items, actions,
+			  &xd->last_flow_error);
+  if (rv != 0)
+    {
+      if (rv == -EINVAL)
+	rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
+      else if (rv == -EEXIST)
+	rv = VNET_FLOW_ERROR_ALREADY_EXISTS;
+      else
+	rv = VNET_FLOW_ERROR_INTERNAL;
+
+      goto done;
+    }
+
   fe->handle = rte_flow_create (xd->device_index, &ingress, items, actions,
 				&xd->last_flow_error);
 
-  if (!fe->handle)
-    rv = VNET_FLOW_ERROR_NOT_SUPPORTED;
-
 done:
   vec_free (items);
   vec_free (actions);