From: Nathan Skrzypczak Date: Fri, 26 Feb 2021 13:32:55 +0000 (+0100) Subject: cnat: coverity fix X-Git-Tag: v21.10-rc0~455 X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F62%2F31462%2F2;p=vpp.git cnat: coverity fix Type: fix Change-Id: I9d562abc8d8f59cfe73ddd4c03a25085f6ad1f84 Signed-off-by: Nathan Skrzypczak --- diff --git a/src/plugins/cnat/cnat_translation.c b/src/plugins/cnat/cnat_translation.c index 8b7cf2451b7..bd456c82fef 100644 --- a/src/plugins/cnat/cnat_translation.c +++ b/src/plugins/cnat/cnat_translation.c @@ -248,7 +248,8 @@ cnat_translation_init_maglev (cnat_translation_t *ct) { u32 a, b, c; a = ip_addr_v4 (&trk->ct_ep[VLIB_TX].ce_ip).data_u32; - b = trk->ct_ep[VLIB_TX].ce_port << 16 | trk->ct_ep[VLIB_RX].ce_port; + b = (u64) trk->ct_ep[VLIB_TX].ce_port << 16 | + (u64) trk->ct_ep[VLIB_RX].ce_port; c = ip_addr_v4 (&trk->ct_ep[VLIB_RX].ce_ip).data_u32; hash_v3_mix32 (a, b, c); hash_v3_finalize32 (a, b, c); @@ -260,7 +261,8 @@ cnat_translation_init_maglev (cnat_translation_t *ct) u64 a, b, c; a = ip_addr_v6 (&trk->ct_ep[VLIB_TX].ce_ip).as_u64[0] ^ ip_addr_v6 (&trk->ct_ep[VLIB_TX].ce_ip).as_u64[1]; - b = trk->ct_ep[VLIB_TX].ce_port << 16 | trk->ct_ep[VLIB_RX].ce_port; + b = (u64) trk->ct_ep[VLIB_TX].ce_port << 16 | + (u64) trk->ct_ep[VLIB_RX].ce_port; c = ip_addr_v6 (&trk->ct_ep[VLIB_RX].ce_ip).as_u64[0] ^ ip_addr_v6 (&trk->ct_ep[VLIB_RX].ce_ip).as_u64[1]; hash_mix64 (a, b, c);