From: Matus Fabian <matfabia@cisco.com>
Date: Tue, 25 Oct 2016 11:19:26 +0000 (-0700)
Subject: VPP-478: SNAT address range overlapping
X-Git-Tag: v17.01-rc0~31
X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F65%2F3565%2F2;p=vpp.git

VPP-478: SNAT address range overlapping

Ignore adding duplicate address.

Change-Id: Icbb76bbcb3a78a18acb1a50d5d8ab777e9f9bd36
Signed-off-by: Matus Fabian <matfabia@cisco.com>
---

diff --git a/plugins/snat-plugin/snat/snat.c b/plugins/snat-plugin/snat/snat.c
index 505f501d250..1a8c93dcf72 100644
--- a/plugins/snat-plugin/snat/snat.c
+++ b/plugins/snat-plugin/snat/snat.c
@@ -202,6 +202,13 @@ void snat_add_address (snat_main_t *sm, ip4_address_t *addr)
 {
   snat_address_t * ap;
 
+  /* Check if address already exists */
+  vec_foreach (ap, sm->addresses)
+    {
+      if (ap->addr.as_u32 == addr->as_u32)
+        return;
+    }
+
   vec_add2 (sm->addresses, ap, 1);
   ap->addr = *addr;