From: Andrew Yourtchenko Date: Fri, 4 Dec 2020 07:22:01 +0000 (+0000) Subject: stats: fix coverity issues X-Git-Tag: v21.06-rc0~68 X-Git-Url: https://gerrit.fd.io/r/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F71%2F30271%2F2;p=vpp.git stats: fix coverity issues Usage of the possibly negative value with subsequent check on it makes coverity very unhappy, so put the check before use. Change-Id: I731fbe6246f9e4212d546fd9277bc1ddcd3c2ec1 Type: fix Signed-off-by: Andrew Yourtchenko --- diff --git a/src/vpp/stats/stat_segment.c b/src/vpp/stats/stat_segment.c index 4244acb1dd0..0b5ea3048d5 100644 --- a/src/vpp/stats/stat_segment.c +++ b/src/vpp/stats/stat_segment.c @@ -330,13 +330,12 @@ vlib_map_stat_segment_init (void) mfd = clib_mem_vm_create_fd (sm->log2_page_sz, mem_name); - /* Set size */ - if ((ftruncate (mfd, memory_size)) == -1) - return clib_error_return (0, "stat segment ftruncate failure"); - if (mfd == -1) return clib_error_return (0, "stat segment memory fd failure: %U", format_clib_error, clib_mem_get_last_error ()); + /* Set size */ + if ((ftruncate (mfd, memory_size)) == -1) + return clib_error_return (0, "stat segment ftruncate failure"); memaddr = clib_mem_vm_map_shared (0, memory_size, mfd, 0, mem_name);